feat: build: automate agent config JSON schema generation from proto+…#58
Open
feat: build: automate agent config JSON schema generation from proto+…#58
Conversation
dngpng
reviewed
Apr 18, 2026
Contributor
dngpng
left a comment
There was a problem hiding this comment.
Quick note on schema versioning ($schema) strictness:
The generated v3 schema currently treats $schema as a generic string (with a default) instead of enforcing an exact value.
Why this matters:
- It weakens schema-level version gating, since validators can accept payloads with mismatched/incorrect
$schemavalues. - Version routing then depends only on app code checks, not the schema contract itself.
Suggestion:
- In
agent-config-v3.schema.json, enforce an exact value for$schema(e.g.const: "https://feros.ai/schemas/agent-config-v3.schema.json"). - When v4 is introduced, add a separate v4 schema file with its own exact value.
- Import can still support multiple versions explicitly (e.g., route by
$schemaand validate against the matching schema, or use aoneOfwrapper).
This preserves strict contracts per version without blocking future schema evolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pydantic